Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogito compatible way

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 10, 2008, 23:25 UTC
Message-ID: <7viqqv410q.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1226353631-3716-1-git-send-email-mkoegler@auto.tuwien.ac.at>

Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:

Show 11 quoted lines

> Current git versions ignore everything after # (called <head> in the
> following) when pushing. Older versions (before cf818348f1ab57),
> interpret #<head> as part of the URL, which make git bail out.
>
> Ignoring the <head> part for push (fetch respects them) is unlogical.
> As branches origin from Cogito, it is the best to correct this by
> using the behaviour of cg-push:
>
> push HEAD to remote refs/heads/<head>
>
> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>

This message was addressed to me, but is it meant for inclusion?

I do not recall seeing an agreement on what the desired behaviour should be from (ex-)Cogito users, if this change of behaviour hurts real world usage of existing git users, andr if so how we ease this change in to the release.

While I'd personally agree matching with whatever cg-push used to do might make the most sense in the end, I am not sure changing of behaviour abruptly like this is a good idea.

I am also not so sure url#branch is illogical; I'd suggest dropping that line from the commit log message in any case.

Show 18 quoted lines

> +
> +Depending on the operation, git will use one of the following
> +refsprecs, if you don't provide one on the command line.
> +`<branch>` is the name of this file in `$GIT_DIR/branches` and
> +`<head>` defaults to `master`.
> +
> +git fetch uses:
> +
> +------------
> +	refs/heads/<head>:refs/heads/<branch>
> +------------
> +
> +git push uses:
>  
>  ------------
> -	refs/heads/<head>:<repository>
> +	HEAD:refs/heads/<head>
>  ------------

Why isn't this "refs/heads/<head>:refs/heads/<head>", by the way?