Re: [PATCH] Allow passing of --directory to git-am.

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2008, 00:11 UTC
Message-ID: <7viqpzbhvr.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49386ABE.2050404@fs.ei.tum.de>

Simon 'corecode' Schubert <corecode@fs.ei.tum.de> writes:

Show 17 quoted lines

> Junio C Hamano wrote:
>> Simon 'corecode' Schubert <corecode@fs.ei.tum.de> writes:
>>
>>> You mean not storing/restoring the flags across an invocation?  No,
>>> that's a different thing.  My patch only adds the --directory option,
>>> it does not fix the previously existing bug.
>>
>> The question is if it _introduces_ a bug that the directory given in the
>> initial invocation of "git am --directory=foo" is lost if an patch does
>> not apply and you need to manually resolve and continue.
>>
>> If it does not introduce such a bug, you do not have the same issue as the
>> old patch.  Otherwise you have the same issue as the old patch.  The
>> question was if you have the same issue or you don't.  Yes?  No?
>
> Yes, that's the issue.  In this regard it behaves bug-compatible with
> the -p and -C options.

If that is the case, and assuming that propagating -C/-p would be a good idea (which I am not sure yet), the patch I sent out earlier (which was flawed somewhat; it should use "$git_apply_opt_extra" where it invokes the "git apply" command) with necessary fix would serve as the basis to implement --directory=<dir>?