git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] strbuf_readlink semantics update.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 25, 2008, 07:23 UTC
Message-ID
<7viqp8afap.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<4952532F.5050704@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 16 quoted lines
> Pierre Habouzit schrieb:
>> On Tue, Dec 23, 2008 at 06:16:01PM +0000, Linus Torvalds wrote:
>>>
>>> On Tue, 23 Dec 2008, Pierre Habouzit wrote:
>>>> when readlink fails, the strbuf shall not be destroyed. It's not how
>>>> read_file_or_gitlink works for example.
>>> I disagree.
>>>
>>> This patch just makes things worse. Just leave the "strbuf_release()" in 
>>> _one_ place.
> ...
> The "append or do nothing" rule is broken by strbuf_getline(), but I agree
> to your reasoning.  How about refining this rule a bit to "do your thing
> and roll back changes if an error occurs"?  I think it's not worth to undo
> allocation extensions, but making reverting first time allocations seems
> like a good idea.  Something like this?

I think this is much better than Pierre's. Pierre's "if it is called strbuf_*, it should always append" is a good uniformity to have in an API, but making the caller suffer for clean-up is going backwards. The reason we use strbuf when we can is so that the callers do not have to worry about memory allocation issues too much.

Previous: René ScharfeNext: Pierre Habouzit
Message 30 of 33 in “Be careful about lstat()-vs-readlink()”
  1. 0/5 Be careful about lstat()-vs-readlink()Linus Torvalds, Dec 17, 2008
  2. 1/5 Add generic 'strbuf_readlink()' helper functionLinus Torvalds, Dec 17, 2008
  3. 2/5 Make 'ce_compare_link()' use the new 'strbuf_readlink()'Linus Torvalds, Dec 17, 2008
  4. 3/5 Make 'index_path()' use 'strbuf_readlink()'Linus Torvalds, Dec 17, 2008
  5. 4/5 Make 'diff_populate_filespec()' use the new 'strbuf_readlink()'Linus Torvalds, Dec 17, 2008
  6. 5/5 Make 'prepare_temp_file()' ignore st_size for symlinksLinus Torvalds, Dec 17, 2008
  7. 6/5 make_absolute_path(): check bounds when seeing an overlong symlinkJunio C Hamano, Dec 17, 2008
  8. 7/5 builtin-blame.c: use strbuf_readlink()Junio C Hamano, Dec 17, 2008
  9. 8/5 combine-diff.c: use strbuf_readlink()Junio C Hamano, Dec 17, 2008
  10. Linus TorvaldsDec 17, 2008
  11. Junio C HamanoDec 17, 2008
  12. Junio C HamanoDec 17, 2008
  13. Mark BurtonDec 18, 2008
  14. Linus TorvaldsDec 18, 2008
  15. René ScharfeDec 18, 2008
  16. Linus TorvaldsDec 18, 2008
  17. Olivier GalibertDec 18, 2008
  18. René ScharfeDec 18, 2008
  19. René ScharfeDec 18, 2008
  20. diff.c: fix pointer type warningRené Scharfe, Dec 19, 2008
  21. Junio C HamanoDec 19, 2008
  22. Junio C HamanoDec 17, 2008
  23. Jay SoffianDec 17, 2008
  24. Linus TorvaldsDec 17, 2008
  25. strbuf_readlink semantics update.Pierre Habouzit, Dec 23, 2008
  26. Pierre HabouzitDec 23, 2008
  27. Linus TorvaldsDec 23, 2008
  28. Pierre HabouzitDec 24, 2008
  29. René ScharfeDec 24, 2008
  30. Junio C HamanoDec 25, 2008
  31. Pierre HabouzitJan 4, 2009
  32. strbuf: instate cleanup rule in case of non-memory errorsRené Scharfe, Jan 6, 2009
  33. Junio C HamanoJan 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.