git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH, resend] git-commit: colored status when color.ui is set

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 9, 2009, 09:00 UTC
Message-ID
<7viqoo26rq.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200901081953.01418.markus.heidelberg@web.de>
Markus Heidelberg <markus.heidelberg@web.de> writes:
Show 23 quoted lines
> When using "git commit" and there was nothing to commit (the editor
> wasn't launched), the status output wasn't colored, even though color.ui
> was set. Only when setting color.status it worked.
>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>  builtin-commit.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/builtin-commit.c b/builtin-commit.c
> index e88b78f..2d90f74 100644
> --- a/builtin-commit.c
> +++ b/builtin-commit.c
> @@ -945,6 +945,9 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
>  
>  	git_config(git_commit_config, NULL);
>  
> +	if (wt_status_use_color == -1)
> +		wt_status_use_color = git_use_color_default;
> +
>  	argc = parse_and_validate_options(argc, argv, builtin_commit_usage, prefix);
>  
>  	index_file = prepare_index(argc, argv, prefix);
My first reaction was:
	When the editor does get launched, what would the new code do with
	your patch?  Would we see bunch of escape codes in the editor now?

But we do disable color explicitly when we generate contents to feed the editor in that case since bc5d248 (builtin-commit: do not color status output shown in the message template, 2007-11-18), so that fear is unfounded.

Thanks for a reminder, will queue.
Previous: Markus HeidelbergNext: Johannes Schindelin
Message 2 of 4 in “git-commit: colored status when color.ui is set”
  1. git-commit: colored status when color.ui is setMarkus Heidelberg, Jan 8, 2009
  2. Junio C HamanoJan 9, 2009
  3. Johannes SchindelinJan 9, 2009
  4. Markus HeidelbergJan 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.