git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add -u: do not fail to resolve a path as deleted

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 28, 2009, 23:32 UTC
Message-ID
<7viqnzj9ay.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7vbptrkqvb.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 26 quoted lines
> After you resolve a conflicted merge to remove the path, "git add -u"
> failed to record the removal.  Instead it errored out by saying that the
> removed path is not found in the work tree, but that is what the user
> wanted to do and failing it is illogical.
>
> This fixes it.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  read-cache.c          |    5 +++++
>  t/t2200-add-update.sh |   20 +++++++++++++++++++-
>  2 files changed, 24 insertions(+), 1 deletions(-)
>
> diff --git a/read-cache.c b/read-cache.c
> index b1475ff..ddc0586 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -1574,6 +1574,11 @@ static void update_callback(struct diff_queue_struct *q,
>  		default:
>  			die("unexpected diff status %c", p->status);
>  		case DIFF_STATUS_UNMERGED:
> +			/*
> +			 * diff-files gives U followed by the work tree state
> +			 * such as M or D, so we can ignore this.
> +			 */
> +			continue;
This is wrong; breaks t3702.
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 3 in “add -u: do not fail to resolve a path as deleted”
  1. add -u: do not fail to resolve a path as deletedJunio C Hamano, Jan 28, 2009
  2. Junio C HamanoJan 28, 2009
  3. Junio C HamanoJan 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.