git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] bisect: use "rev-list --bisect-skip" and remove "filter_skipped" function

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 12, 2009, 08:26 UTC
Message-ID
<7viqmfkuyt.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20090312085140.c22cd336.chriscool@tuxfamily.org>

These (except for the first one which I do not think belongs to the series) look more or less straightforward changes.

One worrysome thing that the series introduces is that you used to hold all the skipped ones in a shell variable $skip and fed it internally to the filter_skipped shell function, but now you give them from the command line. When you have tons of skipped commits, this can easily bust the command line length limit on some system, while the shell may still be Ok with such a large string variable.

Because the operations in rev-list related to bisect are very closely tied to the implementation of the bisect Porcelain anyway, I am wondering if it makes more sense to just feed the name of the toplevel refname hierarchy, i.e. "refs/bisect", as a rev-list parameter and let rev-list enumerate what is skipped, which commits are good and which ones are bad.

Previous: Christian CouderNext: Christian Couder
Message 2 of 3 in “bisect: use "rev-list --bisect-skip" and remove "filter_skipped" function”
  1. 7/7 bisect: use "rev-list --bisect-skip" and remove "filter_skipped" functionChristian Couder, Mar 12, 2009
  2. Junio C HamanoMar 12, 2009
  3. Christian CouderMar 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.