Re: [PATCH v2] New config push.default to decide default behavior for push

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2009, 04:55 UTC
Message-ID: <7viqmayslg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7viqmbakmt.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

> Finn Arne Gangstad <finnag@pvv.org> writes:
>
>> Something like this amended into the last commit? I can amend it on top
>> of the last one and resend if that is better.
>
> Thanks.
>
> I looked at these two patches after squashing them into one, and I think
> it makes sense as the final shape of a two patch series.

I seem to have forgotten to say what the two pieces in the series should look like here. What I meant was a split along these lines:

 (1) introduce the configuration variable, so that people who do not like
     the current default can get a different default, but do not warn;

 (2) start warning to notify the users of possible different settings and
     forcing them to choose now, before we switch the default.

As some people still seem to object to the change of default (and that includes 20-30% of myself), we may end up deciding not to switch the default after all, but even in that case, applying the first half would benefit people who would want different behaviour.

If we were to decide not to switch the default, applying (2) would force people who want the current default to set the configuration only to squelch the message, which is an annoying inconvenience.

But since then I thought about this a bit more, and I am inclined to change my mind. Having (2) will allow people who wish there were a way to have a different default to discover that there is already an easy way to do so. The tradeoff between "a slight inconvenience to traditionalist" vs "helping people to discover the feature designed for them, without which they would be badly burned" does not look too bad to me.