Re: [PATCH] Changed timestamp behavior of options -c/-C/--amend
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 30, 2009, 21:58 UTC
- Message-ID
- <7viqdwilx2.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vljisk1m7.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
> ... > I agree that the issue the patch addresses is worth improving, and I think > it is sensible to default to reuse the timestamp for -C and not to reuse > for --amend. I am not sure about -c myself, but it probably shouldn't > reuse the timestamp by default.
So after realizing that this was about "author" timestamp, I am rescinding this comment about the change of the default for -c and --amend.
But everything else still stands. IOW, I still (1) do think the issue is worth addressing (thanks Erick), (2) the log message can be improved, and (3) --(old|new)-timestamp should be --[no-]reuse-timestamp.