Re: [PATCH] Do not unquote + into ' ' in URLs

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2010, 22:26 UTC
Message-ID: <7viq45eswt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <db9c97908966fa332be07b2a9f5215679e35b9e0.1279920066.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 5 quoted lines

> Since 9d2e942 (decode file:// and ssh:// URLs, 2010-05-23) the URL
> logic unquotes escaped URLs.  For the %2B type of escape, this is
> conformant with RFC 2396.  However, it also unquotes + into a space
> character, which is only appropriate for the query strings in HTTP.
> This notably broke fetching from the gtk+ repository.

Wait a minute.

> Based on the discussion, I would consider this a bugfix that should go
> in 1.7.2.1.

Some form of this may need to be applied to help the client side, but what will happen to

  http-backend.c::get_info_refs()
   -> http-backend.c::get_parameter()
     -> http-backend.c::get_parameters()
       -> url.c::url_decode_parameter_value()
         -> url.c::url_decode_internal()

codepath, which is the server-side handing of query strings?