git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] t1011 (sparse checkout): style nitpicks

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 2, 2010, 17:31 UTC
Message-ID
<7viq3sncpy.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vmxt5lyjh.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> From: Jonathan Nieder <jrnieder@gmail.com>
>>
>> Tweak the rest of the script to more closely follow the test
>> style guide.  Guarding setup commands with test_expect_success
>> makes it easy to see the scope in which some particular data is
>> used; removal of whitespace after >redirection operators is just
>> for consistency.
>>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>
> What happened to the 'test -z "$(cmd)" discards exit status from cmd' part
> of Jonathan's patch?
Sorry, I was confused.

Please disregard the above; it took me a while to realize that this 5-patch series is a re-roll of what I queued, which in turn Jonathan's nitpick is based on, and you took the advice while redoing 2/5.

Thanks.
Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 4 of 10 in “nd/fix-sparse-checkout v2”
  1. 0/5 nd/fix-sparse-checkout v2Nguyễn Thái Ngọc Duy, Jul 31, 2010
  2. 1/5 t1011 (sparse checkout): style nitpicksNguyễn Thái Ngọc Duy, Jul 31, 2010
  3. Junio C HamanoAug 2, 2010
  4. Junio C HamanoAug 2, 2010
  5. 2/5 unpack-trees: only clear CE_UPDATE|CE_REMOVE when skip-worktree is always setNguyễn Thái Ngọc Duy, Jul 31, 2010
  6. Jonathan NiederAug 8, 2010
  7. 3/5 unpack-trees: let read-tree -u remove index entries outside sparse areaNguyễn Thái Ngọc Duy, Jul 31, 2010
  8. 4/5 unpack-trees: do not check for conflict entries too earlyNguyễn Thái Ngọc Duy, Jul 31, 2010
  9. 5/5 unpack-trees: mark new entries skip-worktree appropriatelyNguyễn Thái Ngọc Duy, Jul 31, 2010
  10. Jonathan NiederAug 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.