Re: [PATCH 3/3] bisect: check for mandatory argument of 'bisect replay'

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2010, 17:58 UTC
Message-ID: <7viq16m0tk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201010120456.35411.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 25 quoted lines

>> >  bisect_replay () {
>> > 
>> > +	test "$#" -eq 1 || die "No logfile given"
>> > 
>> >  	test -r "$1" || die "cannot read $1 for replaying"
>> >  	bisect_reset
>> >  	while read git bisect command rev
>> 
>> While at it perhaps you could do something like:
>> 
>> bisect_replay () {
>> +	test "$#" -lt 1 || die "No logfile given"
>> +	test "$#" -gt 1 || die "Too many argument. Please give only one logfile."
>>  	test -r "$1" || die "cannot read $1 for replaying"
>>  	bisect_reset
>>  	while read git bisect command rev
>
> I mean:
>
> bisect_replay () {
> +	test "$#" -lt 1 && die "No logfile given"
> +	test "$#" -gt 1 && die "Too many argument. Please give only one logfile."
>  	test -r "$1" || die "cannot read $1 for replaying"
>  	bisect_reset
>  	while read git bisect command rev

That suggests that the original patch is buggy as well, in that it says "No logfile given" when it gets two.

How about checking with 1 and saying "Give me only one logfile" and be done with it?