git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] system_path: use a static buffer

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 16, 2011, 20:43 UTC
Message-ID
<7vipvi7q5g.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1300293183-26354-1-git-send-email-cmn@elego.de>
Carlos Martín Nieto <cmn@elego.de> writes:
Show 8 quoted lines
> Make system_path behave like the other path functions by using a
> static buffer, fixing a memory leak.
>
> Also make sure the prefix pointer is always initialized to either
> PREFIX or NULL.
>
> Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
> ---
Have you made sure all the callers are Ok with this change?

If somebody called system_path(GIT_EXEC_PATH), saved the result in a variable without copying, and then called system_path(ETC_GITATTRIBUTES), his variable may now have a value unrelated to GIT_EXEC_PATH, and you would fix all such callers to save the value away with strdup().

Previous: Carlos Martín NietoNext: Carlos Martín Nieto
Message 23 of 48 in “Fix some errors reported by valgrind”
  1. 0/3 Fix some errors reported by valgrindCarlos Martín Nieto, Mar 14, 2011
  2. 1/3 make_absolute_path: Don't try to copy a string to itselfCarlos Martín Nieto, Mar 14, 2011
  3. Jeff KingMar 14, 2011
  4. Junio C HamanoMar 14, 2011
  5. Carlos Martín NietoMar 14, 2011
  6. Junio C HamanoMar 14, 2011
  7. Carlos Martín NietoMar 15, 2011
  8. Carlos Martín NietoMar 15, 2011
  9. Junio C HamanoMar 15, 2011
  10. Carlos Martín NietoMar 15, 2011
  11. Nguyen Thai Ngoc DuyMar 16, 2011
  12. Carlos Martín NietoMar 16, 2011
  13. Nguyen Thai Ngoc DuyMar 16, 2011
  14. Nguyen Thai Ngoc DuyMar 16, 2011
  15. Carlos Martín NietoMar 16, 2011
  16. 2/3 setup_path(): Free temporary bufferCarlos Martín Nieto, Mar 14, 2011
  17. Jeff KingMar 14, 2011
  18. Carlos Martín NietoMar 14, 2011
  19. system_path: use a static bufferCarlos Martín Nieto, Mar 16, 2011
  20. Erik Faye-LundMar 16, 2011
  21. Carlos Martín NietoMar 16, 2011
  22. system_path: use a static bufferCarlos Martín Nieto, Mar 16, 2011
  23. Junio C HamanoMar 16, 2011
  24. system_path: use a static bufferCarlos Martín Nieto, Mar 17, 2011
  25. system_path: use a static bufferCarlos Martín Nieto, Mar 17, 2011
  26. Junio C HamanoMar 18, 2011
  27. Carlos Martín NietoMar 21, 2011
  28. Jeff KingMar 21, 2011
  29. Carlos Martín NietoMar 21, 2011
  30. Jeff KingMar 21, 2011
  31. Carlos Martín NietoMar 21, 2011
  32. Nguyen Thai Ngoc DuyMar 18, 2011
  33. PATH_MAX (Re: [PATCH] system_path: use a static buffer)Jonathan Nieder, Mar 18, 2011
  34. Nguyen Thai Ngoc DuyMar 18, 2011
  35. Carlos Martín NietoMar 21, 2011
  36. Lasse MakholmMar 21, 2011
  37. Nguyen Thai Ngoc DuyMar 21, 2011
  38. 1/2 wrapper.c: add xgetcwd()Nguyễn Thái Ngọc Duy, Mar 18, 2011
  39. 2/2 setup_gently: use xgetcwd()Nguyễn Thái Ngọc Duy, Mar 18, 2011
  40. Junio C HamanoMar 14, 2011
  41. Carlos Martín NietoMar 14, 2011
  42. Jeff KingMar 15, 2011
  43. t/README: Add a note about running commands under valgrindCarlos Martín Nieto, Mar 15, 2011
  44. Junio C HamanoMar 15, 2011
  45. Carlos Martín NietoMar 15, 2011
  46. 3/3 clone: Free a few pathsCarlos Martín Nieto, Mar 14, 2011
  47. Jonathan NiederMar 14, 2011
  48. Junio C HamanoMar 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.