Re: [PATCH v2] run-command: prettify -D_FORTIFY_SOURCE workaround

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2011, 22:34 UTC
Message-ID: <7vipvh1iml.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110316073239.GJ5988@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 10 quoted lines

>  static NORETURN void die_child(const char *err, va_list params)
>  {
> ...
> -	unused = write(child_err, "fatal: ", 7);
> -	unused = write(child_err, msg, len);
> -	unused = write(child_err, "\n", 1);
> +	if (write(child_err, "fatal: ", 7) ||
> +	    write(child_err, msg, len) ||
> +	    write(child_err, "\n", 1))
> +		; /* yes, gcc -D_FORTIFY_SOURCE, we know there was an error. */

Strictly speaking, this changes behaviour by stopping at the first failure from write(2), but I don't think we care.

Thanks.