Re: [RFD] Expanded Pretty Format Placeholders Proposal

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 18, 2011, 07:18 UTC
Message-ID: <7vipvgzyl0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1300399206.2004.22.camel@walleee>

Will Palmer <wmpalmer@gmail.com> writes:

Show 9 quoted lines

>> I somehow had an impression that you will be using "" to quote strings to
>> protect leading or trailing whitespaces, and if you were to support double
>> quotes anyway, \" and \\ become a very natural thing to do (so does your
>> "close parenthesis inside dq").
>
> I do have double-quoted strings implemented, but in trying to break the
> big-ugly-POC patch down into more-manageable changes, I questioned the
> need for it when %x20 or the "magic" space-if-nonempty might do just as
> well for most cases, so I took it out of the initial patch.

True enough; %x20 is probably acceptable and %xXX is what we already have anyway. Besides, values in the configuration file needs to use dq when they have whitespaces in them, and it would make it trickier to read if the language used in value (i.e. the one you are designing when used as part of alias) overused dq and bs.

I wasn't objecting to %-quoting. I just wanted to make sure that the reason you favored it over dq was sane and well thought out.

Thanks.