Re: [PATCH 1/4] enter_repo: do not modify input

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2011, 20:24 UTC
Message-ID: <7vipo4bj3f.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CABURp0rKRb+fZG5erKz08Dz+4d7mjoL842zbcA7uzZ8N5Qtn1Q@mail.gmail.com>

Phil Hord <phil.hord@gmail.com> writes:

Show 6 quoted lines

> diff --git a/daemon.c b/daemon.c
> index 4c8346d..9253192 100644
> --- a/daemon.c
> +++ b/daemon.c
> @@ -108,11 +108,11 @@ static void NORETURN daemon_die(const char *err,
> va_list params)

Corrupt and unappliable patch.

> -		if (path[0] == '~') {
> -			char *newpath = expand_user_path(path);
> +		strncpy(used_path, path, len); used_path[len] = 0 ;

Do not write two statements on a single line; extra SP before ';'.