Re: [RFC/WIP PATCH] Use config value rebase.editor as editor when starting git rebase -i

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2011, 18:37 UTC
Message-ID: <7vipnvfk70.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201110111956.08829.kumbayo84@arcor.de>

Peter Oberndorfer <kumbayo84@arcor.de> writes:

> Using $GIT_EDITOR or core.editor config var for this is not possible
> since it is also used to start the commit message editor for reword action.

Your tool _could_ be smart about this issue and inspect the contents to launch a real editor when it is fed a material not for sequencing, but that feels hacky.

> * GIT_EDITOR env var is not honored anymore after this change.

Care to explain? "git var" knows magic about a few variables like GIT_EDITOR and GIT_PAGER.

	$ git config core.editor vim
	$ GIT_EDITOR=vi EDITOR=emacs git var GIT_EDITOR
        vi
	$ unset GIT_EDITOR; EDITOR=emacs git var GIT_EDITOR
        emacs

> * Should git_rebase_editor be in git-rebase--interactive.sh instead

Probably yes.

> * How should the config be called?

Given that in the longer term we would be using a unified sequencer machinery for not just rebase-i but for am and cherry-pick, I would advise against calling this anything "rebase". How does "sequence.edit" sound?

You need to be prepared to adjust your code to deal with new kinds of sequencing insns in the insn sheet and possibly a format change of the insn sheet itself.