git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/5] http: handle proxy proactive authentication

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 13, 2012, 19:35 UTC
Message-ID
<7viph32znu.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120412224230.GA22988@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> But you snipped the later part of my message, which is that the "http"
> in "http_proxy" does _not_ matter. It is about which destinations to
> apply the proxy to, not how you talk to the proxy (and the latter is what
> should matter for the credentials).

Oh, yes, I am in violent agreement. The language the http clients (browsers etc) talk to the proxy may be part of HTTP specification, but it is definitely different from the "http" talked with the origin servers.

Show 17 quoted lines
>> > Not splitting "http" and "http-proxy" does have a slight confusion,...
>> 
>> Ok, so how about this as a replacement patch for what I have had for the
>> past few days?
>
> My other message argued "the http-proxy distinction might be important,
> but probably isn't". But I didn't talk about "the http-proxy distinction
> might break helpers". The stock helpers will be fine; they are totally
> clueless about what the protocol means, and just treat it as a string to
> be matched. But for something like osxkeychain, where it is converting
> the protocol string into some OS-specific magic value, it does matter,
> and http-proxy would cause it to exit in confusion.
>
> It looks like OS X defines a SOCKS type and an HTTPProxy type for its
> keychain API. So in either case, it should probably be updated to handle
> these new types. And I guess that argues for making the distinction,
> since at least one helper does want to care about it.
OK.  Sounds like we are in agreement.

Nelson, care to re-roll the series, with fixes discussed in this thread rolled into the second patch?

Previous: Jeff KingNext: Jeff King
Message 10 of 13 in “http: handle proxy proactive authentication”
  1. 2/5 http: handle proxy proactive authenticationNelson Benitez Leon, Mar 13, 2012
  2. Junio C HamanoApr 9, 2012
  3. Junio C HamanoApr 10, 2012
  4. Junio C HamanoApr 12, 2012
  5. Jeff KingApr 12, 2012
  6. Junio C HamanoApr 12, 2012
  7. Jeff KingApr 12, 2012
  8. Junio C HamanoApr 12, 2012
  9. Jeff KingApr 12, 2012
  10. Junio C HamanoApr 13, 2012
  11. Jeff KingApr 13, 2012
  12. Jeff KingApr 13, 2012
  13. Junio C HamanoApr 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.