Re: Fix potential hang in https handshake (v3)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 19, 2012, 21:21 UTC
- Message-ID
- <7vipa6i2dk.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20121019210851.GD24184@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
>> + if (max_fd < 0 &&
>> + select_timeout.tv_sec > 0 ||
>> + select_timeout.tv_usec > 50000) {
>> + select_timeout.tv_sec = 0;
>> + select_timeout.tv_usec = 50000;
>> + }
>
> Should there be parentheses separating the || bit from the &&?Yeah, I think there should be. Thanks for sharp eyes.