git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fix potential hang in https handshake (v3)

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 19, 2012, 21:21 UTC
Message-ID
<7vipa6i2dk.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20121019210851.GD24184@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
>> +			if (max_fd < 0 &&
>> +			    select_timeout.tv_sec > 0 ||
>> +			    select_timeout.tv_usec > 50000) {
>> +				select_timeout.tv_sec  = 0;
>> +				select_timeout.tv_usec = 50000;
>> +			}
>
> Should there be parentheses separating the || bit from the &&?
Yeah, I think there should be.  Thanks for sharp eyes.
Previous: Jeff King
Message 3 of 3 in “Fix potential hang in https handshake (v3)”
  1. szager@google.comOct 19, 2012
  2. Jeff KingOct 19, 2012
  3. Junio C HamanoOct 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.