Re: [PATCH 2/2] format-patch: give --reroll-count a short synonym -v

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2013, 01:28 UTC
Message-ID: <7vip7dviqy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vpq1lvmtz.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> "Philip Oakley" <philipoakley@iee.org> writes:
>
>>> +test_expect_success 'reroll count (-v)' '
>>> + rm -fr patches &&
>>> + git format-patch -o patches --cover-letter -v 4 master..side >list
>>> &&
>>
>> Shouldn't this be using the sticked form -v4 as described in the
>> commit message and gitcli?
>
> I personally do not care too deeply either way.

Actually, I do care. And in this case both should work.

    Separating argument from the option
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    You can write the mandatory option parameter to an option as a separate
    word on the command line.  That means that all the following uses work:

    ----------------------------
    $ git foo --long-opt=Arg
    $ git foo --long-opt Arg
    $ git foo -oArg
    $ git foo -o Arg
    ----------------------------

As "reroll-count" must always be followed by nth (in other words, it is not optional), the following does not apply.

    However, this is *NOT* allowed for switches with an optional value, where the
    'sticked' form must be used: