Re: [PATCH] count-objects: output "KiB" instead of "kilobytes"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 2, 2013, 22:01 UTC
- Message-ID
- <7vip44a8xl.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1364903010-644-1-git-send-email-mihai@mihaic.ro>
Mihai Capotă <mihai@mihaic.ro> writes:
Show 20 quoted lines
> The code uses division by 1024. Also, the manual uses "KiB".
>
> Signed-off-by: Mihai Capotă <mihai@mihaic.ro>
> ---
> builtin/count-objects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/count-objects.c b/builtin/count-objects.c
> index 9afaa88..ecc13b0 100644
> --- a/builtin/count-objects.c
> +++ b/builtin/count-objects.c
> @@ -124,7 +124,7 @@ int cmd_count_objects(int argc, const char **argv, const char *prefix)
> printf("garbage: %lu\n", garbage);
> }
> else
> - printf("%lu objects, %lu kilobytes\n",
> + printf("%lu objects, %lu KiB\n",
> loose, (unsigned long) (loose_size / 1024));
> return 0;
> }This breaks existing tests (5301, 7408 and 5700); I noticed it too late and wasted 20 minutes, having to re-run today's integration cycle.
Next time, please run the testsuite before sending a patch.