Re: [PATCH] Add .gitconfig variable commit.gpg-sign

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 22, 2013, 23:43 UTC
Message-ID: <7vip3em8rs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAASwCXf3YHmdQ_eSkShyzn5VniO=ufm3VTqV1JVOUN610bzE_A@mail.gmail.com>

Joel Jacobson <joel@trustly.com> writes:

> Signed-off-by: Joel Jacobson <joel@trustly.com>
> ---
>  builtin/commit.c | 4 +++-

No docs?  No tests?

As to the design, any regular configuration variable settings must be overridable from the command line for a single invocation. Please design an escape hatch in, for somebody who has this configuration variable set, but does not want to sign this commit he is about to make.

Also do we generally use dash in the configuration variable names? I thought the norm was section.CamelCase.

Show 7 quoted lines

> +       if (!strcmp(k, "commit.gpg-sign"))
> +               return git_config_string(&sign_commit, k, v);
>         if (!strcmp(k, "commit.cleanup"))
>                 return git_config_string(&cleanup_arg, k, v);
>
> --
> --to=gitster@pobox.com