git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] allow git-svn fetching to work using serf

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 8, 2013, 16:22 UTC
Message-ID
<7vip0l10ow.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1373170849-9150-1-git-send-email-mackyle@gmail.com>
"Kyle J. McKay" <mackyle@gmail.com> writes:
Show 27 quoted lines
> From: "Kyle J. McKay" <mackyle@gmail.com>
>
> This patch allows git-svn to fetch successfully using the
> serf library when given an https?: url to fetch from.
>
> Unfortunately some svn servers do not seem to be configured
> well for use with the serf library.  This can cause fetching
> to take longer compared to the neon library or actually
> cause timeouts during the fetch.  When timeouts occur
> git-svn can be safely restarted to fetch more revisions.
>
> A new temp_is_locked function has been added to Git.pm
> to facilitate using the minimal number of temp files
> possible when using serf.
>
> The problem that occurs when running git-svn fetch using
> the serf library is that the previously used temp file
> is not always unlocked before the next temp file needs
> to be used.
>
> To work around this problem, a new temp name is used
> if the temp name that would otherwise be chosen is
> currently locked.
>
> Version v2 of the patch introduced a bug when changing the _temp_cache
> function to use the new temp_is_locked function at the suggestion of a
> reviewer.  That has now been resolved.
Thanks; I've queued this version to 'pu' at least tentatively.

Is everybody who discussed the issue happy with the direction of this patch?

Previous: Kyle J. McKay
Message 7 of 7 in “allow git-svn fetching to work using serf”
  1. 0/2 allow git-svn fetching to work using serfKyle J. McKay, Jul 7, 2013
  2. 1/2 Git.pm: add new temp_is_locked functionKyle J. McKay, Jul 7, 2013
  3. David RothenbergerJul 18, 2013
  4. Kyle J. McKayJul 18, 2013
  5. Jonathan NiederJul 18, 2013
  6. 2/2 git-svn: allow git-svn fetching to work using serfKyle J. McKay, Jul 7, 2013
  7. Junio C HamanoJul 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.