Re: [PATCH-RFC] Rewrite ls-tree to behave more like "/bin/ls -a"
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 29, 2005, 18:44 UTC
- Message-ID
- <7vhdgloos9.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <1117317729.11542.32.camel@jmcmullan.timesys>
>>>>> "JM" == Jason McMullan <jason.mcmullan@timesys.com> writes:
JM> On Sat, 2005-05-28 at 00:05 -0700, Junio C Hamano wrote:
Show 5 quoted lines
>> - Unlike the old ls-tree behaviour that used paths arguments to >> restrict output (not that it worked as intended---as pointed >> out in the mailing list discussion, it was quite incoherent), >> this rewrite uses paths arguments to specify what to show. >> ...
JM> This behavior pattern is very agreeable. I'll take it!
Glad to know we are in agreement.
BTW, long after finishing the rewrite, I realized that all of the problems you raised did not exist in the very original version of ls-tree, but were bugs in _your_ patch that added the paths restriction. I was merely cleaning up your mess for you without knowing what I was doing. ;-) Not that I do not like what the resulting code does, though.
I am not going to re-submit this to Linus right now, since he seems to be quiet here and spending more time and attention to the kernel, which is what I want to see. When Linus starts pulling in update for GIT, and if you see this one not applied to his tree, please remind him.