Re: [PATCH] diff-tree: stop on broken output pipe

From: Junio C Hamano <junkio@cox.net>
Date: Jan 6, 2006, 22:36 UTC
Message-ID: <7vhd8ht24d.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0601020116020.11331@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 10 quoted lines

> 	Without this, on my iBook git-whatchanged keeps running when I 
> 	quit "less". I have to interrupt the process a second time. No
> 	idea why it works on Linux.
>
> -		if (!no_commit_id)
> -			printf("%s%c", header, diff_options.line_termination);
> +		if (!no_commit_id && printf("%s%c", header,
> +				diff_options.line_termination) < 0)
> +			die("broken output pipe");
>  		header = NULL;

There are tons of output other than this printf() and catching an output error only on this one and assuming that is a broken pipe somehow feels doubly wrong to me.