Re: Make git-rev-list and git-rev-parse argument parsing stricter
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 25, 2006, 22:40 UTC
- Message-ID
- <7vhd7sorrw.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0601251655580.2644@evo.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 6 quoted lines
> If you pass it a filename without the "--" marker to separate it from > revision information and flags, we now require that the file in question > actually exists. This makes mis-typed revision information not be silently > just considered a strange filename. >... > Comments?
I think it is a good safety measure. People has to say "git rev-list -- git-commit-script" if they are interested in historical paths, but that is less common. We could even go stronger and always require '--', but that is probably too much for normal use. I like the balance you struck here.