git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix vc git

From
Junio C Hamano <junkio@cox.net>
Date
Dec 22, 2006, 00:52 UTC
Message-ID
<7vhcvo92fx.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<8e745ecf0612210359j3f895521r1fff497a512253d3@mail.gmail.com>
"Duncan Mak" <duncan@a-chinaman.com> writes:
Show 12 quoted lines
> --- a/contrib/emacs/vc-git.el
> +++ b/contrib/emacs/vc-git.el
> @@ -58,7 +58,7 @@
>   (with-temp-buffer
>     (let* ((dir (file-name-directory file))
>            (name (file-relative-name file dir)))
> -      (when dir (cd dir))
> +      (when (file-exists-p dir) (cd dir))
>       (and (ignore-errors (eq 0 (call-process "git" nil '(t nil) nil
> "ls-files" "-c" "-z" "--" name)))
>            (let ((str (buffer-string)))
>              (and (> (length str) (length name))

I wonder what would happen when (file-name-directory file) returns nil with this change...

Previous: Duncan MakNext: Duncan Mak
Message 4 of 10 in “fix vc git”
  1. fix vc gitDuncan Mak, Dec 21, 2006
  2. Jakub NarebskiDec 21, 2006
  3. Duncan MakDec 21, 2006
  4. Junio C HamanoDec 22, 2006
  5. Duncan MakDec 22, 2006
  6. Junio C HamanoDec 22, 2006
  7. Alexandre JulliardDec 22, 2006
  8. Duncan MakDec 22, 2006
  9. Alexandre JulliardDec 22, 2006
  10. Duncan MakDec 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.