Re: Creating attachments using git-format-patch

From: Junio C Hamano <junkio@cox.net>
Date: Mar 3, 2007, 22:49 UTC
Message-ID: <7vhct27xk2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <loom.20070303T215950-974@post.gmane.org>

Panagiotis Issaris <takis.issaris@uhasselt.be> writes:

Show 5 quoted lines

> I've been trying to start using git-format-patch together with
> git-send-email, but I've encountered some problems. The
> mailinglist I want to send the patches to, requires patches to
> be sent as attachments. So, I tried using the --attach option
> of git-format-patch.

Strictly speaking, I think --attach option is misnamed. It's sole purpose is to create a multipart/mixed whose first part is the commit log message and the second part is the patch text to help cases where the patch text is not UTF-8 but the log message is.

We mark the second part inline because it is easier to review if the patch is shown inline in MUA.

For now, I think you could edit "inline;" to "attachment;".

We could introduce a new option "--inline" that does what the current "--attach" does, and make "--attach" write "attachment;" instead of "inline;" there, but that changes the behaviour, and people who are used to use "--attach" to send out patches to mailing lists suddenly start sending more cumbersome-to-read variant, so...