Re: [PATCH 04/13] support rollback on writes to checksummed files
- From
Junio C Hamano <junkio@cox.net>
- Date
- Apr 5, 2007, 22:58 UTC
- Message-ID
- <7vhcrumnsh.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <56b7f5510704051529k55a96bdfy5b072b220f8269a7@mail.gmail.com>
"Dana How" <danahow@gmail.com> writes:
Show 5 quoted lines
> From 1df9e443ce11365f955b83e70365670ff9ada8d6 Mon Sep 17 00:00:00 2001 > From: Dana How <how@deathvalley.cswitch.com> > Date: Thu, 5 Apr 2007 13:13:42 -0700 > Subject: [PATCH 04/13] support rollback on writes to checksummed files > add struct sha1posn, sha1mark(), sha1undo() to csum-file.[ch]
Have an empty line after "Subject:". Begin a sentence with a capital (i.e. "Add struct...").
Explain *why* these changes are needed, not just *what* the patch does -- the latter can be read from the patch text.