Re: [bug in next ?] git-fetch/git-push issue

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2007, 23:22 UTC
Message-ID: <7vhck0mg5y.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071105225540.GA10988@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Which I guess is what you were trying to accomplish by removing the
> peer_ref, though I think that doesn't distinguish between "didn't match
> a remote ref" and "had an error." Perhaps we just need an error flag in
> the ref struct?

I agree that makes the most sense.

As Steffen has been advocating on another thread, depending on your workflow, you do not care about some classes of push errors per pushed refs. The update of the remote and local tracking refs should be done in sync (i.e. if the remote wasn't updated, never update the corresponding local), but it can depend on the nature of the failure if a failure to update a remote ref should result in the non-zero exit status from git-push as a whole.

And to implement that, per-ref error flag would be a good way to go, methinks.