Re: [PATCH] Fix git-show-branch --current when not on a branch

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2008, 22:05 UTC
Message-ID: <7vhcck4t6z.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.10.0805240049400.3980@euler.pkqs.net>

Stephan Beyer <s-beyer@gmx.net> writes:

Show 12 quoted lines

> builtin-show-branch.c relied on resolve_ref() to return
> "refs/heads/foo" if on branch foo.  But if not on a branch,
> it returns "HEAD".  Hence, `head + pfxlen' (i.e. head+11)
> is a memory address beyond the "HEAD" string, so that
> further operation leads to access of uninitialized memory.
>
> This commit fixes the bug by just not adding the
> "refs/heads/"-length offset.  So append_one_rev() operates
> on "refs/heads/foo" instead of "foo", which still works.
> But now it also operates correctly on "HEAD".
>
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>

Thanks for a patch and (more importantly) prodding..

Show 14 quoted lines

>  builtin-show-branch.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/builtin-show-branch.c b/builtin-show-branch.c
> index 019abd3..412eba0 100644
> --- a/builtin-show-branch.c
> +++ b/builtin-show-branch.c
> @@ -782,8 +782,7 @@ int cmd_show_branch(int ac, const char **av, const char *prefix)
>  				has_head++;
>  		}
>  		if (!has_head) {
> -			int pfxlen = strlen("refs/heads/");
> -			append_one_rev(head + pfxlen);
> +			append_one_rev(head);

This changes the output for normal case.  How about doing it like this instead?

 builtin-show-branch.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin-show-branch.c b/builtin-show-branch.c
index 019abd3..a383323 100644
--- a/builtin-show-branch.c
+++ b/builtin-show-branch.c
@@ -782,8 +782,8 @@ int cmd_show_branch(int ac, const char **av, const char *prefix)
 				has_head++;
 		}
 		if (!has_head) {
-			int pfxlen = strlen("refs/heads/");
-			append_one_rev(head + pfxlen);
+			int offset = !prefixcmp(head, "refs/heads/") ? 11 : 0;
+			append_one_rev(head + offset);
 		}
 	}