git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make git reflog expire honour core.sharedRepository.

From
Junio C Hamano <junio@pobox.com>
Date
Jun 15, 2008, 22:47 UTC
Message-ID
<7vhcbuco2w.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1213565862-23247-1-git-send-email-madcoder@debian.org>
Pierre Habouzit <madcoder@debian.org> writes:
Show 18 quoted lines
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>  builtin-reflog.c       |    1 +
>  t/t1301-shared-repo.sh |   15 +++++++++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
>
>  Some people like to have logAllRefUpdates even for bare repositories, and if
>  shared, git-gc breaks them.
>
> diff --git a/builtin-reflog.c b/builtin-reflog.c
> index 897d1dc..430929f 100644
> --- a/builtin-reflog.c
> +++ b/builtin-reflog.c
> @@ -308,6 +308,7 @@ static int expire_reflog(const char *ref, const unsigned char *sha1, int unused,
>  		} else if (cmd->updateref && commit_ref(lock)) {
>  			status |= error("Couldn't set %s", lock->ref_name);
>  		}
> +		adjust_shared_perm(log_file);

Why is it sane to do this unconditionally, instead of putting in another else or something?

Previous: Pierre HabouzitNext: Pierre Habouzit
Message 2 of 5 in “Make git reflog expire honour core.sharedRepository.”
  1. Make git reflog expire honour core.sharedRepository.Pierre Habouzit, Jun 15, 2008
  2. Junio C HamanoJun 15, 2008
  3. Pierre HabouzitJun 15, 2008
  4. Johannes SchindelinJun 16, 2008
  5. Johannes SchindelinJun 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.