Re: On PPC64, the parsing of integers on the commandline is bitshifted.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 7, 2008, 21:42 UTC
- Message-ID
- <7vhc9wijsq.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <CxVxAoKmEQsrgFdHEvL0sjkgBBIVZ3Zvsl0pPSuDSfH_8xM8NOSGfw@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
Show 11 quoted lines
> Brandon Casey wrote: >> Robin H. Johnson wrote: >>> In a 64-bit userland, big-endian environment, the parser gets integers >>> wrong. >> >> There is a fix on master. Can you try that out? >> Unfortunately, looks like it did not make it into 1.5.6.5 > > Also, just so you know, it is test-parse-options.c that is broken, not > the parsing code. So, the rest of git should be using an int with > OPT_INTEGER() and should operate correctly.
Yup, that is why it is not on 'maint' --- but somebody should audit the parse_options() users in the real programs to make sure that there is no similar breakages, namely, giving a pointer to long to OPT_INTEGER().