Re: [PATCH] Only update the cygwin-related configuration during state auto-setup

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 28, 2008, 03:27 UTC
Message-ID: <7vhc6xh010.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081027192018.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 13 quoted lines

> Quoting Junio C Hamano <gitster@pobox.com>:
>
>> This is the answer to the question I asked in:
>> 
>>  http://thread.gmane.org/gmane.comp.version-control.git/97986/focus=98066
>> 
>> Perhaps we should use a separate variable as the original patch did, in:
>> 
>>   http://article.gmane.org/gmane.comp.version-control.git/97987
>> 
>> How about doing it like this instead?
>
> Junio, may I ask what the status of this patch is? I see you did not write tests nor commit message --- are you waiting for others to write them?

Heh, Alex's ack is good enough for me as far as the code itself is concerned, but I do want these "fixes" accompanied by additional tests to reproduce to avoid future regressions, and this being a Cygwin fix, I am not really the right person to write tests nor run them.