Re: [PATCH 2/2] git-remote: add verbose mode
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2008, 10:15 UTC
- Message-ID
- <7vhc66zmi5.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1226913150-26088-2-git-send-email-crquan@gmail.com>
crquan@gmail.com writes:
> From: Denis ChengRq <crquan@gmail.com> > > Signed-off-by: Cheng Renquan <crquan@gmail.com>
Your other one (I am assuming the other one is also from you) has "From: Cheng Renquan <crquan@gmail.com>" and this is "From: Denis ChengRq <crquan@gmail.com>". We'd prefer to keep the same person under a single name in "git shortlog" list. Under which name do you want to be known?
Please describe in what sense this is "verbose", iow, what additional information is added by this patch, in your proposed commit log message.
Show 11 quoted lines
> @@ -40,10 +40,13 @@ static int opt_parse_track(const struct option *opt, const char *arg, int not)
> return 0;
> }
>
> -static int fetch_remote(const char *name)
> +static int fetch_remote(const char *name, const char *url)
> {
> const char *argv[] = { "fetch", name, NULL };
> - printf("Updating %s\n", name);
> + if (verbose)
> + printf("Updating %s (%s)\n", name, url);Are you guaranteeing that url is not NULL at this point in the code? If so how?
How does this "--verbose" command the users give "git remote" relate to the "--verbose" option the underlying "git fetch" has? IOW, do you tell "git fetch" to be verbose as well? If so, how? If not, why not?