git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix deletion of last character in levenshtein distance

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 19, 2008, 13:13 UTC
Message-ID
<7vhc63svsl.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0811191053250.30769@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 10 quoted lines
> Okay, I understand now, _after_ having looked at the original 
> levenshtein.c.
>
> IOW you could have made my task of reviewing your patch much easier.
>
> Anyway, here is my
>
> 	Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Thanks for the bugfix,

In other words, even the original author's head exploded without looking at extra context lines around the patch.

It is a sure sign that the original implementation was too scantily described, and that the fix was not explained well in the proposed commit log message (i.e. in what corner cases the original was bad in what way, and how the patch fixes it).

I shouldn't have to decipher the original and the fixed version with pencil and paper when re-reviewing Dscho's Ack.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 6 of 12 in “Fix deletion of last character in levenshtein distance”
  1. Fix deletion of last character in levenshtein distanceSamuel Tardieu, Nov 18, 2008
  2. Matthieu MoyNov 18, 2008
  3. Johannes SchindelinNov 19, 2008
  4. Samuel TardieuNov 19, 2008
  5. Johannes SchindelinNov 19, 2008
  6. Junio C HamanoNov 19, 2008
  7. Document levenshtein.cJohannes Schindelin, Nov 20, 2008
  8. Samuel TardieuNov 20, 2008
  9. Document levenshtein.cJohannes Schindelin, Nov 20, 2008
  10. Jon LoeligerNov 20, 2008
  11. Sverre RabbelierNov 20, 2008
  12. Johannes SchindelinNov 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.