Re: [PATCH] GIT_SSH does not override ssh in git-svn

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2009, 21:40 UTC
Message-ID: <7vhbw6qfuq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4A89C6F8.3010100@fastmail.fm>

Karthik R <karthikr@fastmail.fm> writes:

Show 10 quoted lines

> +my $git_ssh_user_set = 1 if defined $ENV{GIT_SSH};
> +if ($git_ssh_user_set) {
> +       # If GIT_SSH is set, also set SVN_SSH...
> +       $ENV{SVN_SSH} = $ENV{GIT_SSH};
> +       # ... and escape \s in shell-variable on Windows
> +       if ($^O eq 'MSWin32' || $^O eq 'msys') {
> +               $ENV{SVN_SSH} =~ s/\\/\\\\/g;
> +       }
> +}
> +

Why not just

	if (defined $ENV{GIT_SSH}) {
        	...

???

Show 5 quoted lines

> $Git::SVN::Log::TZ = $ENV{TZ};
> $ENV{TZ} = 'UTC';
> $| = 1; # unbuffer STDOUT
> -- 
> 1.5.4.3