Re: [PATCH] git-p4: Avoid modules deprecated in Python 2.6.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2009, 18:14 UTC
Message-ID: <7vhbvucuj5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1251305536-25887-1-git-send-email-reillyeon@qotw.net>

Reilly Grant <reillyeon@qotw.net> writes:

> The popen2, sha and sets modules are deprecated in Python 2.6 (sha in
> Python 2.5).  Both popen2 and sha are not actually used in git-p4.
> Replace usage of sets.Set with the builtin set object.

Does the code already rely on a feature not found in Python older than 2.4 before your patch? Otherwise I would have liked to see the last sentence like this:

    Replace usage of sets.Set with the builtin set object, which has
    been available since Python 2.4.

    This change makes the script unusable with Python older than 2.4,
    which was released in 2004. Hopefully nobody uses ancient 2.3.

So that I did not have to check myself to get a feel of how safe this change is.