git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 1/2] Report exec errors from run-command

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 25, 2009, 07:46 UTC
Message-ID
<7vhbrfebrh.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vr5qjecbb.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Ilari Liusvaara <ilari.liusvaara@elisanet.fi> writes:
>
>> Previously run-command was unable to report errors happening in exec
>> call. Change it to pass errno from failed exec to errno value at
>> return.
>>
>> The errno value passing can be done by opening close-on-exec pipe and
>> piping the error code through in case of failure. In case of success,
>> close-on-exec closes the pipe on successful exec and parent process
>> gets end of file on read.
>
> Thanks; I think overall this is a good idea, even though I have no clue
> if WIN32 side wants a similar support.

By the way, at least it should be pretty straightforward to add a test or two for [1/2] if not [2/2].

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “Report remote helper exec failures”
  1. 0/2 Report remote helper exec failuresIlari Liusvaara, Dec 24, 2009
  2. 1/2 Report exec errors from run-commandIlari Liusvaara, Dec 24, 2009
  3. Junio C HamanoDec 25, 2009
  4. Junio C HamanoDec 25, 2009
  5. Junio C HamanoDec 25, 2009
  6. Ilari LiusvaaraDec 25, 2009
  7. Johannes SixtDec 25, 2009
  8. Ilari LiusvaaraDec 25, 2009
  9. 2/2 Improve transport helper exec failure reportingIlari Liusvaara, Dec 24, 2009
  10. Junio C HamanoDec 25, 2009
  11. Ilari LiusvaaraDec 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.