git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 01/13] parse-options: stop when encounter a non-option

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 6, 2010, 02:36 UTC
Message-ID
<7vhbkd72w1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1277911526-12105-1-git-send-email-struggleyb.nku@gmail.com>
Bo Yang <struggleyb.nku@gmail.com> writes:
> Since we need to support the syntax like:
> -L n1,m1 path1 -L n2,m2 path2.
>
> So, make the parse-options API not stop with a
The above sentence does not parse well.
Show 47 quoted lines
> non-option, but report the status and go on parsing
> the following.
>
> Thanks-to: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
> ---
>  parse-options.c |    3 ++-
>  parse-options.h |    3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/parse-options.c b/parse-options.c
> index 0fa79bc..cbb49d3 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -374,7 +374,7 @@ int parse_options_step(struct parse_opt_ctx_t *ctx,
>  			if (parse_nodash_opt(ctx, arg, options) == 0)
>  				continue;
>  			if (ctx->flags & PARSE_OPT_STOP_AT_NON_OPTION)
> -				break;
> +				return PARSE_OPT_NON_OPTION;
>  			ctx->out[ctx->cpidx++] = ctx->argv[0];
>  			continue;
>  		}
> @@ -456,6 +456,7 @@ int parse_options(int argc, const char **argv, const char *prefix,
>  	switch (parse_options_step(&ctx, options, usagestr)) {
>  	case PARSE_OPT_HELP:
>  		exit(129);
> +	case PARSE_OPT_NON_OPTION:
>  	case PARSE_OPT_DONE:
>  		break;
>  	default: /* PARSE_OPT_UNKNOWN */
> diff --git a/parse-options.h b/parse-options.h
> index 7435cdb..407697a 100644
> --- a/parse-options.h
> +++ b/parse-options.h
> @@ -161,7 +161,8 @@ extern NORETURN void usage_msg_opt(const char *msg,
>  enum {
>  	PARSE_OPT_HELP = -1,
>  	PARSE_OPT_DONE,
> -	PARSE_OPT_UNKNOWN
> +	PARSE_OPT_NON_OPTION,
> +	PARSE_OPT_UNKNOWN,
>  };
>  
>  /*
> -- 
> 1.7.0.2.273.gc2413.dirty
Previous: Bo Yang
Message 16 of 16 in “parse-options: stop when encounter a non-option”
  1. 01/13 parse-options: stop when encounter a non-optionBo Yang, Jun 30, 2010
  2. 02/13 parse-options: add two helper functionsBo Yang, Jun 30, 2010
  3. 03/13 add the basic data structure for line level historyBo Yang, Jun 30, 2010
  4. Junio C HamanoJul 6, 2010
  5. Bo YangJul 6, 2010
  6. 04/13 refactor parse_locBo Yang, Jun 30, 2010
  7. 05/13 parse the -L optionsBo Yang, Jun 30, 2010
  8. 06/13 export three functions from diff.cBo Yang, Jun 30, 2010
  9. 07/13 add range clone functionsBo Yang, Jun 30, 2010
  10. 08/13 map/take range to parentBo Yang, Jun 30, 2010
  11. 09/13 print the line logBo Yang, Jun 30, 2010
  12. 10/13 map/print ranges along traversing the history topologicallyBo Yang, Jun 30, 2010
  13. 11/13 add --always-print optionBo Yang, Jun 30, 2010
  14. 12/13 add two test casesBo Yang, Jun 30, 2010
  15. 13/13 some document updateBo Yang, Jun 30, 2010
  16. Junio C HamanoJul 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.