Re: [PATCH] diff.c: fix a graph output bug

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 9, 2010, 00:15 UTC
Message-ID: <7vhbk9o6ie.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4c35eb6c.21078e0a.1455.ffffe42d@mx.google.com>

struggleyb.nku@gmail.com writes:

> From: Bo Yang <struggleyb.nku@gmail.com>
>
> Ouput the line_prefix ahead of color sequence.

Justification for the patch, and/or a better bug description ("when run with this combination of options, X gets painted in that color that is not meant to be used for X") please?

Show 27 quoted lines

>
> Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
> ---
>  diff.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/diff.c b/diff.c
> index 3aa695d..17873f3 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -2627,8 +2627,7 @@ static void fill_metainfo(struct strbuf *msg,
>  			    (!fill_mmfile(&mf, two) && diff_filespec_is_binary(two)))
>  				abbrev = 40;
>  		}
> -		strbuf_addf(msg, "%s%sindex %s..", set,
> -			    line_prefix,
> +		strbuf_addf(msg, "%s%sindex %s..", line_prefix, set,
>  			    find_unique_abbrev(one->sha1, abbrev));
>  		strbuf_addstr(msg, find_unique_abbrev(two->sha1, abbrev));
>  		if (one->mode == two->mode)
> -- 
> 1.7.0.2.273.gc2413.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html