Re: [PATCH 04/10] Add treap implementation
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 8 quoted lines
> +/* Left accessors. */
> +#define trp_left_get(a_base, a_field, a_node) \
> + (trpn_pointer(a_base, a_node)->a_field.trpn_left)
> +#define trp_left_set(a_base, a_field, a_node, a_left) \
> + do { \
> + trpn_modify(a_base, a_node); \
> + trp_left_get(a_base, a_field, a_node) = (a_left); \
> + } while(0)Need SP after "while" (there are other occurrences).
Show 5 quoted lines
> +a_attr a_type MAYBE_UNUSED *a_pre##search(struct trp_root *treap, a_type *key) \
> +{ \
> + int cmp; \
> + uint32_t ret = treap->trp_root; \
> + while (~ret && (cmp = (a_cmp)(key, trpn_pointer(a_base,ret)))) { \SP after "," (same for nsearch)
Junio C Hamano <gitster@pobox.com>