Re: Histogram diff, libgit2 enhancement, libgit2 => git merge (GSOC)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 20, 2011, 18:25 UTC
- Message-ID
- <7vhbaxwswo.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <op.vsm1yszq2m56ex@localhost.localdomain>
"Pavel Raiskup" <xraisk00@gmail.com> writes:
> I have one theoretical question -- what if the benchmarking/study of > histogram diff leads to conclusion that this algorithm will not be > useful for upstream? Does it mean "fail" in terms of GSOC?
Not necessarily. A negative result is often as valuable as a positive result.
It will take a clearly good implementation to justify why a negative result is a success, though. If it is clear to the reviewers that the implementation is poorly done, the negative conclusion does not necessarily mean that use of the histogram algorithm is a bad approach---it would just mean the particular implementation that didn't implement it well was, and then the GSoC task may have to be marked as a failure. But otherwise, if the submission is done with the usual code quality we would expect from contributors and explained well in its log message (either positive or negative), I would say it should be considered a "success".