Re: [PATCH] git-completion: Add git help completion for aliases

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2011, 21:48 UTC
Message-ID: <7vhbawno11.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4D871972.7080008@elegosoft.com>

Jakob Pfender <jpfender@elegosoft.com> writes:

Show 22 quoted lines

> Enable bash completion for "git help <alias>", analogous to "git
> <alias>", which was already implemented.
>
> Signed-off-by: Jakob Pfender <jpfender@elegosoft.com>
> ---
>  contrib/completion/git-completion.bash |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash
> b/contrib/completion/git-completion.bash
> index 893b771..f9a74d3 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1506,7 +1506,7 @@ _git_help ()
>  		;;
>  	esac
>  	__git_compute_all_commands
> -	__gitcomp "$__git_all_commands
> +	__gitcomp "$__git_all_commands $(__git_aliases)
>  		attributes cli core-tutorial cvs-migration
>  		diffcore gitk glossary hooks ignore modules
>  		repository-layout tutorial tutorial-2

This patch may not be _wrong_ per-se, but it it useful in practice?

I dunno.

Don't people usually use aliases so that they do not have to type long command names that would need completion?