Re: [PATCH] revert: Hide '-r' option in default usage

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 13, 2011, 18:09 UTC
Message-ID: <7vhba2m39n.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110413132146.GB26760@kytes>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 21 quoted lines

> Hi Junio,
>
> Junio C Hamano writes:
>> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>> 
>> > Since the '-r' command-line option is a no-op provided only for
>> > backward compatiblity, don't advertise it in the default usage.
>> >
>> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> > ---
>> 
>> Thanks.
>> 
>> It would have saved me a lot of time if you wrote that this option has
>> been a no-op since abd6970 (cherry-pick: make -r the default, 2006-10-05),
>> but the commit didn't remove it from the usage string, and it somehow
>> survived 9509af6 (Make git-revert & git-cherry-pick a builtin, 2007-03-01)
>> and later f810379 (Make builtin-revert.c use parse_options, 2007-10-07),
>> and it is about time to stop advertising it.
>
> Thanks.  I didn't realize there was so much history to write about.

Not necessarily in the final commit message; before "---" would have been sufficient.

> Has you queued this somewhere?

Sorry, after spending time to dig the history to see when we made this a no-op to ensure that it was sufficiently long time ago and wrote my finding in the message to you, I forgot to apply the patch. Will queue.

Thanks.