Re: [PATCH v3 2/2] Move git-dir for submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 16, 2011, 17:34 UTC
Message-ID: <7vhb5hi7lg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1313178913-25617-3-git-send-email-iveqy@iveqy.com>

Fredrik Gustafsson <iveqy@iveqy.com> writes:

Show 15 quoted lines

> diff --git a/git-submodule.sh b/git-submodule.sh
> index bc1d3fa..ace6c1d 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -122,14 +122,53 @@ module_clone()
>  	path=$1
>  	url=$2
>  	reference="$3"
> +	gitdir=
> +	gitdir_base=
> +	name=$(module_name "$path")
> +	if test -z "$name"
> +	then
> +		name="$path"
> +	fi

This conditional is not needed; module_name dies when it cannot find the name for the path, as it should.

If the defaulting to the path itself were a good idea (which I do not think it is), that should be done in module_name so that other callers that tried to find the name for a given path that does not have a named module would get a consistent result.