Re: [PATCH] rev-list: Demonstrate breakage with --ancestry-path --all
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 25, 2011, 23:49 UTC
- Message-ID
- <7vhb55gig1.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7v4o15hyxx.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> Brad King <brad.king@kitware.com> writes: > >> The option added by commit ebdc94f3 (revision: --ancestry-path, >> 2010-04-20) does not work properly in combination with --all, at least >> in the case of a criss-cross merge: >> >> b---bc >> / \ / >> a X >> \ / \ >> c---cb > > Hmm, what should --ancestry-path do given more than one positive commit to > begin with, let alone --all?
I actually think that this does not have much to do with "criss-cross"-ness. Instead of computing those that can be reached from cb, we are computing those that can be reached from either b, c or cb.
This needs fixing, but it takes a bit more than a quick hack. Stay tuned ;-)
Thanks.