Re: [PATCH] completion: add format-patch options to send-email

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 15, 2012, 23:28 UTC
Message-ID: <7vhapvuxgo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121015224857.GA2156@goldbirke>

SZEDER Gábor <szeder@ira.uka.de> writes:

Show 5 quoted lines

>> +	cd test
>
> This 'cd' makes all subsequent tests to be executed in a different
> repository than previously, which breaks 'checkout completes ref
> names'.

Yeah, thanks for spotting and yelling at it ;-).

We really need to be careful about tests that cd around. Even the ones that only go down and expect the rest of the test to run in that subdirectory may later have to be modified by somebody to run back at the original level, and writing "cd ..", which leads to all sorts of problems, becomes too tempting.

Show 18 quoted lines

>> +'
>> +
>>  test_expect_success 'basic' '
>>  	run_completion "git \"\"" &&
>>  	# built-in
>> @@ -228,4 +244,9 @@ test_expect_success 'general options plus command' '
>>  	test_completion "git --no-replace-objects check" "checkout "
>>  '
>>  
>> +test_expect_success 'send-email' '
>> +	test_completion "git send-email --cov" "--cover-letter " &&
>> +	test_completion "git send-email ma" "master "
>> +'
>> +
>>  test_done
>> -- 
>> 1.7.12.1
>>