Re: [PATCH] gitk: Display the date of a tag in a human friendly way.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2013, 23:50 UTC
Message-ID: <7vhamwse2c.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1357314431-32710-1-git-send-email-wildfire@progsoc.org>

Anand Kumria <wildfire@progsoc.org> writes:

Show 25 quoted lines

> By selecting a tag within gitk you can display information about it.
> This information is output by using the command
>
>  'git cat-file tag <tagid>'
>
> This outputs the *raw* information from the tag, amongst which is the
> time - in seconds since the epoch. As useful as that value is, I find it
> a lot easier to read and process time which it is something like:
>
>  "Mon Dec 31 14:26:11 2012 -0800"
>
> This change will modify the display of tags in gitk like so:
>
>   @@ -1,7 +1,7 @@
>    object 5d417842efeafb6e109db7574196901c4e95d273
>    type commit
>    tag v1.8.1
>   -tagger Junio C Hamano <gitster@pobox.com> 1356992771 -0800
>   +tagger Junio C Hamano <gitster@pobox.com> Mon Dec 31 14:26:11 2012 -0800
>
>    Git 1.8.1
>    -----BEGIN PGP SIGNATURE-----
>
> Signed-off-by: Anand Kumria <wildfire@progsoc.org>
> ---

Sounds like a sensible thing to do but I didn't check how else (other than purely for displaying) this string is used.

Paul, the patch is not made against your tree, so if you choose to take it you would need to strip the leading directory at the top.

Thanks.

PS. I haven't received a pull request from you for a while; are there accumulated changes I should be pulling in before -rc0 of the next release we are working on?

Show 16 quoted lines

>  gitk-git/gitk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index d93bd99..aae1c58 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -10675,7 +10675,7 @@ proc showtag {tag isnew} {
>      set linknum 0
>      if {![info exists cached_tagcontent($tag)]} {
>  	catch {
> -           set cached_tagcontent($tag) [exec git cat-file tag $tag]
> +           set cached_tagcontent($tag) [exec git cat-file -p $tag]
>  	}
>      }
>      if {[info exists cached_tagcontent($tag)]} {