Re: [PATCH] git-daemon: --inetd implies --syslog

From: Junio C Hamano <junkio@cox.net>
Date: Nov 14, 2005, 22:01 UTC
Message-ID: <7vfypyx50s.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4379006E.8020607@op5.se>

Andreas Ericsson <ae@op5.se> writes:

> That shouldn't be a problem because;
> 1) handle() dupes the connected socket to stdin and stdout, but not stderr.

I am afraid that

$ git whatchanged -s -S'FIXME' daemon.c

tells me otherwise.  Whatever we do in handle() is too late to matter.

diff-tree 7c3693f1f240e17772c864fad35bc16226038fc8 (from 6a2e50f9dfdca7ac572bbe30dd0efdf19ca250f6)
Author: lars.doelle@on-line.de <lars.doelle@on-line.de>
Date:   Thu Sep 8 03:50:01 2005 +0200

    [PATCH] git-daemon --inetd
    
    git-daemon using inetd. does not work properly. inetd routes stderr onto the
    network line just like stdout, which was apparently not expected to be so.
    
    As the result of this, the stream is closed by the receiver, because some
    "Packing %d objects\n" originating from pack_objects is first reported over
    the line instead of the expected pack_header, and so the SIGNATURE test
    fails.  Here is a workaround.
    
    Signed-off-by: Junio C Hamano <junkio@cox.net>