Re: git on HP-UX

From: Junio C Hamano <junkio@cox.net>
Date: Jul 7, 2006, 00:20 UTC
Message-ID: <7vfyhe465i.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1152197629.7720.10.camel@dv>

Pavel Roskin <proski@gnu.org> writes:

Show 11 quoted lines

>> I needed following changes in order to make git compile on HP-UX:
>> +ifeq ($(uname_S),HP-UX)
>> +	NO_IPV6 = YesPlease
>> +	NO_CURL = YesPlease
>
> Is there any fundamental problem with curl and IPv6 on HP-UX?  I don't
> think so.
>
> Sorry for using your path as a bad example, but the appearance of such
> patches is a perfect argument for a real configure script.  If we
> continue patching Makefile, we'll drown in such conditionals.

Conditionals like 'ifdef NO_IPV6' in Makefile are good, but conditionals switch on platforms to set/reset them are not. A configure script to set them in config.mak.gen is the way to go, I would agree.

> I hope the Autoconf based configure is on its way to git, but I don't
> see in in the "pu" branch yet.  I'm not very keen about reinventing
> Autoconf and hacking a hand-made configure script.

OK, you half-convinced me. The other half came from a recent series of patches to try using 'which' to detect executables, which is another common mistake handcrafted configure script makes, which autoconf people have solved for us long time ago.